fixed action settings save issue #691
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an action settings save issue by simplifying the update logic in Redux slices. The changes remove conditional property existence checks and type casting, replacing them with direct property assignment.
- Simplified update logic by removing conditional checks for property existence
- Changed value type from union type to boolean in action settings interface
- Added TypeScript error suppression comments for generic function typing issues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/acf-options-page/src/store/config/watch/watch.slice.ts | Removed conditional property check and type casting in updateWatch reducer |
| apps/acf-options-page/src/store/config/action/settings/action-settings.slice.ts | Narrowed value type to boolean and simplified updateActionSettings reducer |
| export interface IActionSettingsRequest { | ||
| name: string; | ||
| value: boolean | string | number; | ||
| value: boolean; |
There was a problem hiding this comment.
Changing the value type from boolean | string | number to just boolean is a breaking change that could cause runtime errors if callers are still passing string or number values. Consider maintaining backward compatibility or ensuring all call sites are updated.
Copilot uses AI. Check for mistakes.
apps/acf-options-page/src/store/config/action/settings/action-settings.slice.ts
Show resolved
Hide resolved
|
View your CI Pipeline Execution ↗ for commit 747aa9b
☁️ Nx Cloud last updated this comment at |
|
1 participant
No description provided.